Use toggleClass instead of [ bool ? "addClass" : "removeClass" ]#77
Closed
xavi- wants to merge 1 commit intojquery:masterfrom
Closed
Use toggleClass instead of [ bool ? "addClass" : "removeClass" ]#77xavi- wants to merge 1 commit intojquery:masterfrom
xavi- wants to merge 1 commit intojquery:masterfrom
Conversation
Member
|
Thanks, landed in 956697b. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several times in the jquery-ui code base a class is conditionally added to an element using this construct:
elem[ bool ? "addClass" : "removeClass" ]("foo"). I propose that$.fn.toggleClassbe used instead. I feel this change will make the code less verbose and easier to read.Ticket #6764